Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test validation of task collection payload #1891

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Oct 10, 2024

Close #1882

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa changed the base branch from main to new-task-collection October 10, 2024 12:44
Base automatically changed from new-task-collection to main October 10, 2024 12:57
@tcompa tcompa marked this pull request as ready for review October 10, 2024 13:16
Copy link

github-actions bot commented Oct 10, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 12.0 0.87 0.6 0.6
power 394.0 423.4 0.93 381.8 381.8
dataset 149.4 159.8 0.93 142.0 142.0
project 46.8 53.0 0.88 49.7 49.7
job 27.5 30.2 0.91 34.4 34.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 7.8 0.85 2.2 2.2
power 138.3 144.6 0.96 652.4 652.4
dataset 137.4 141.3 0.97 905.6 905.6
project 47.3 51.1 0.93 283.9 283.9
job 37.6 40.1 0.94 225.0 225.0

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.5 8.5 1.00 0.1 0.1
power 7.9 8.3 0.95 0.1 0.1
dataset 7.6 8.5 0.89 0.1 0.1
project 9.7 11.1 0.87 2.3 2.3
job 7.8 8.3 0.94 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.4 6.8 0.94 0.8 0.8
power 6.4 6.5 0.98 0.8 0.8
dataset 6.7 7.1 0.94 0.8 0.8
project 6.4 6.6 0.97 0.8 0.8
job 6.3 6.4 0.98 0.8 0.8

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.7 12.7 0.92 0.8 0.8
power 25.3 28.5 0.89 29.4 29.4
dataset 19.4 21.2 0.92 16.9 16.9
project 25.5 29.0 0.88 21.2 21.2
job 11.5 13.1 0.88 0.8 0.8

POST /api/v2/project/3/dataset/417/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 150.1 159.9 0.94 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.3 5.4 0.98 0.2 0.2
power 5.1 5.1 1.00 0.2 0.2
dataset 5.1 5.1 1.00 0.2 0.2
project 5.4 5.0 1.08 0.2 0.2
job 5.1 5.0 1.02 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 262.9 263.7 1.00 0.2 0.2

Copy link

github-actions bot commented Oct 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  _aux_functions_tasks.py
  fractal_server/app/routes/auth
  _aux_auth.py
  group.py
  fractal_server/app/schemas/v2
  task_collection.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 993df2f into main Oct 10, 2024
18 checks passed
@tcompa tcompa deleted the 1882-add-validation-of-task-collection-payload branch October 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation of task-collection payload
1 participant