Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cheatcodes to use single cheatcode libfunc #46

Closed
cptartur opened this issue Jul 6, 2023 · 0 comments · Fixed by #39
Closed

Migrate cheatcodes to use single cheatcode libfunc #46

cptartur opened this issue Jul 6, 2023 · 0 comments · Fixed by #39
Assignees
@cptartur

Comments

@cptartur
Copy link
Member

cptartur commented Jul 6, 2023

software-mansion/protostar#2072

Instead of implementing custom library functions we should use one general library function with signature

extern fn cheatcode<const selector: felt252>(
    input: Span<felt252>
) -> Span<felt252> implicits() nopanic;

All cheatcodes should be implemented using this function
@cptartur cptartur added this to the Forge milestone Jul 6, 2023
@cptartur cptartur moved this to In Progress in Starknet foundry Jul 6, 2023
@cptartur cptartur self-assigned this Jul 6, 2023
@cptartur cptartur mentioned this issue Jul 6, 2023
Merged
Radinyn pushed a commit that referenced this issue Jul 7, 2023
@cptartur @piotmag769
General cheatcode (#39)
c0cf5ca 
Closes #46

---------

Co-authored-by: Piotr Magiera <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Jul 7, 2023
@bartekryba bartekryba mentioned this issue Jul 24, 2023
Open
@MaksymilianDemitraszek MaksymilianDemitraszek removed this from the Forge milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

Labels
None yet
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

General cheatcode foundry-rs/starknet-foundry
2 participants
@MaksymilianDemitraszek @cptartur