feat: allow remapping of solidity files #9604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
jsvisa
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
@grandizzy PTAL thanks. |
grandizzy
approved these changes
Jan 7, 2025
| @@ -308,3 +320,131 @@ impl Provider for RemappingsProvider<'_> { | |||
| Some(Config::selected_profile()) | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
looks good, another approach to write remapping tests is similar with
foundry/crates/forge/tests/cli/config.rs
Line 600 in 5e72c69
zerosnacks
reviewed
Jan 7, 2025
Comment on lines
+73
to
+76
| // Special handling for .sol file remappings, only allow one remapping per source file. | ||
| if remapping.name.ends_with(".sol") && !remapping.path.ends_with(".sol") { | ||
| return; | ||
| } |
There was a problem hiding this comment.
From preliminary tests it doesn't appear we support remappings w/ Vyper sources
Not sure if this is known and / or worth spending time on implementing or something we should document as a limitation in the book (https://book.getfoundry.sh/config/vyper#5-limitations)
cc @klkvr
There was a problem hiding this comment.
Vyper doesn't have a concept of remappings at all, so I think it should be fine
zerosnacks
approved these changes
Jan 7, 2025
|
ping @klkvr would be great to have your input when you get a chance. thank you! |
klkvr
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #6706
Solution