feat(forge): flatten #506
Merged
feat(forge): flatten #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jan 19, 2022
Comment on lines
+95
to
+102
| match self.output { | ||
| Some(output) => { | ||
| std::fs::create_dir_all(&output.parent().unwrap())?; | ||
| std::fs::write(&output, flattened)?; | ||
| println!("Flattened file written at {}", output.display()); | ||
| } | ||
| None => println!("{}", flattened), | ||
| }; |
There was a problem hiding this comment.
writing to a file is perhaps redundant because you could just do
forge flatten Contract.sol > flattened.sol
either way you'd need to provide the output path
But I have no strong feelings about this argument
There was a problem hiding this comment.
correct and i've got no string feelings either, happy to change if needed
There was a problem hiding this comment.
leaning towards removing the output option, @gakonst
There was a problem hiding this comment.
I think let's keep cuz I like "intuitively" that you can just consume it this way without knowing OS level things like pipes/redirects, even if they are really basic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #312