Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in $-zf-bp-value name #12420

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

javierm
Copy link
Contributor

@javierm javierm commented Apr 17, 2022

Description

After issue #12080 was fixed in pull request #12195, there was still a warning when compiling SCSS:

DEPRECATION WARNING on line 369 of scss/util/_mixins.scss: !global
assignments won't be able to declare new variables in future versions.
Consider adding `$-zf-bp-value: null` at the top level

The reason was a typo in the assigned variable name, which had "pb" instead of "bp".

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

There was a warning when compiling SCSS:

DEPRECATION WARNING on line 369 of scss/util/_mixins.scss: !global
assignments won't be able to declare new variables in future versions.
Consider adding `$-zf-bp-value: null` at the top level

The reason was a typo in the assigned variable name, which had "pb"
instead of "bp".
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants