fix: add missing foundation.js reference comment #11938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SassNinja
reviewed
Dec 13, 2019
|
@SassNinja in 6.4.3 it was still there and it is helpful as reference for users to link / reference the full foundation.js file. See https://github.com/foundation/foundation-sites/blob/v6.4.3/docs/layout/default.html#L85 |
|
I should probably move it after the vendor bundle. |
|
|
Not so quick ;-) |
joeworkman
added a commit
that referenced
this pull request
Dec 13, 2019
Foundation 6.6.1 has fixes for issues introduced with 6.6 Check out the details below: - 🐛 [#](#11925) - Fix sticky breakpoint check - 🐛 [#](#11936) - Update composer.json for packagist.org - 🐛 [#](#11938) - add missing foundation.js reference comment Thanks to the amazing people who contributed code or documentation to the 6.6.1 release. Foundation wouldn't happen without you! * [Daniel Ruf](https://github.com/DanielRuf) * [Kai](https://github.com/SassNinja) * [Joe Workman](https://github.com/joeworkman) * [phpfui](https://github.com/phpfui)
|
This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there: https://foundation.discourse.group/t/foundation-v6-6-1-shipped/67/1 |
This was referenced Mar 10, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing foundation.js reference comment again
Types of changes
Checklist
developordevelop-v...).