Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also support data-pattern for Abide #11673

Merged
merged 1 commit into from Jul 26, 2019
Merged

Also support data-pattern for Abide #11673

merged 1 commit into from Jul 26, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Feb 12, 2019

Description

Also support data-pattern for Abide.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf
Copy link
Contributor Author

Still have to create some tests.

@kball
Copy link
Contributor

kball commented Jul 26, 2019

I think this is reasonable as a standalone given our current state of trying to clean up old PRs and re-kickstart the project. Going to merge as is.

@kball kball merged commit 873c5de into foundation:develop Jul 26, 2019
@DanielRuf DanielRuf deleted the feature/abide-support-data-pattern branch July 26, 2019 04:18
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form validation with custom patterns fails if javascript is disabled
3 participants