Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test latest Node.js #11635

Merged
merged 1 commit into from Dec 21, 2018
Merged

ci: test latest Node.js #11635

merged 1 commit into from Dec 21, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

We should test latest / node (alias for same) to fail early (we do not want to change / use 11 when 12 comes out and just maintain the list of LTS versions).

  • Closes

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf requested a review from ncoden December 20, 2018 07:05
@DanielRuf DanielRuf changed the title ci:test latest Node.js ci: test latest Node.js Dec 20, 2018
@ncoden
Copy link
Contributor

ncoden commented Dec 20, 2018

Well, that is bad

@DanielRuf Is this good to merge or did the PR contained any sensitive data?

@DanielRuf
Copy link
Contributor Author

It's good to merge now. I've revoked my token (I should have the files in the global ignore file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants