Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate position:absolute in progress-bar #11597

Merged
merged 1 commit into from Nov 19, 2018
Merged

fix: remove duplicate position:absolute in progress-bar #11597

merged 1 commit into from Nov 19, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

There is a duplicate position: absolute in the generated code as the absolute-center mixin already uses it.

  • Closes

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

ncoden
ncoden approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @DanielRuf next time please open a single pull request for all similar changes.

@ncoden
Copy link
Contributor

ncoden commented Nov 19, 2018

Note: this doens't fix anything. Use style or refactor.

@ncoden ncoden merged commit d62a9c2 into foundation:develop Nov 19, 2018
@DanielRuf
Copy link
Contributor Author

Note: this doens't fix anything. Use style or refactor.

Well, you could have waited so I could amend the commit but now it's too late.

@DanielRuf DanielRuf deleted the fix/progress-bar-remove-duplicate-position-absolute branch November 20, 2018 05:33
ncoden pushed a commit that referenced this pull request Jan 11, 2019
@ncoden
Use pull request #11597 from DanielRuf/fix/progress-bar-remove-duplic…
124f45f 
…ate-position-absolute for v6.5.0

8cd5454 fix: remove duplicate position:absolute in progress-bar

Signed-off-by: Nicolas Coden <[email protected]>
@ncoden ncoden mentioned this pull request Jan 12, 2019
Merged
11 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
Progress Bar scss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden