fix: ensure Dropdown aria-labelledby to have an ID #11572 #11573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
force-pushed
the
fix/dropdown-aria-missing-id-11572
branch
from
6cd5944 to
5ddb04b
Compare
3 tasks
silenceway
approved these changes
Nov 2, 2018
|
Note: I checked all others usages of |
ncoden
added a commit
that referenced
this pull request
Nov 12, 2018
…2 for v6.5.0 5ddb04b fix: ensure Dropdown aria-labelledby to have an ID #11572 adce391 fix: revert inadvertent substitution of Dropdown "aria-labelledby" attribute Signed-off-by: Nicolas Coden <[email protected]>
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Nov 12, 2018
…ng-id-11572 for v6.5.1 5ddb04b fix: ensure Dropdown aria-labelledby to have an ID foundation#11572 adce391 fix: revert inadvertent substitution of Dropdown "aria-labelledby" attribute Signed-off-by: Nicolas Coden <[email protected]>
|
This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there: https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1 |
This was referenced Mar 10, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11572
Description
Currently, Dropdown generate a random id for
aria-labelledbyif it is not set to target the anchor. But the anchor id is never set.This pull request fix this by setting the anchor id with the generated one if the anchor doens't have an ID already.
Closes #11572
Types of changes
Checklist
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).