Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix various bugs in Tabs & Accordion deep linking #11527 #11530

Merged
merged 4 commits into from
Oct 11, 2018
Merged

fix: fix various bugs in Tabs & Accordion deep linking #11527 #11530

merged 4 commits into from
Oct 11, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Oct 9, 2018

Description

Fix various bugs related to deep-linking in Tabs and Accordion:

  • Prevent scroll to the initialization anchor at initialization
  • Prevent scroll to others components' anchors
  • Ensure Tab deep-linking to redirect to hashes with #

Compatible with 6.5

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@ncoden ncoden requested a review from DanielRuf October 9, 2018 22:42
@ncoden ncoden added this to the 6.5.0 milestone Oct 9, 2018
@ncoden ncoden mentioned this pull request Oct 9, 2018
Closed
3 tasks
@ncoden ncoden force-pushed the fix/tabs-accordion-deep-linking-11527 branch 2 times, most recently from ad06d3b to 7bccec6 Compare October 11, 2018 19:51
@ncoden ncoden merged commit af886cb into foundation:develop Oct 11, 2018
ncoden added a commit that referenced this pull request Oct 11, 2018
@ncoden
Use pull request #11530 from ncoden/fix/tabs-accordion-deep-linking-1…
3c194db 
…1527 for v6.5.0

33c55db fix: fix scroll to deep-linking default anchor on initialization in Tabs/Accordion
8d4a13e fix: prevent Tabs/Accordion to scroll to others components' anchors
7bccec6 fix: ensure Tab deep-linking to redirect to hash with #
9fbc2ee test: add visual test for Tabs deep-linking

Signed-off-by: Nicolas Coden <[email protected]>
@ncoden ncoden mentioned this pull request Oct 11, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf Awaiting requested review from DanielRuf

Assignees
No one assigned
Labels
Accordion bug fix Tabs
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Regression: Accordion scrolls to first anchor even if no deeplink was supplied
1 participant
@ncoden