docs: use correct namespace for DropdownMenu/OffCanvas events (v6.5) #11526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion#11523 Document events with the namespace of the triggered event instead of the class name. There is not ideal but this is better than having a documentation that doesn't match the described event. This fix is compatible with Foundation <= v6.5.0 Closes foundation#11523
3 tasks
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document events with the namespace of the triggered event instead of the class name. There is not ideal but this is better than having a documentation that doesn't match the described event.
Changes: use
DropdownmenuandOffcanvasas namespace for the documentation of DropdownMenu and OffCanvas events.This fix is compatible with
foundation-sites <= 6.5.0Foundation >= 6.5 (
develop) already updated the event names to match the class name.Closes #11523
Types of changes
Checklist
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).