Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swipe docs #11495

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Fix swipe docs #11495

merged 1 commit into from
Sep 7, 2018

Conversation

gforcada
Copy link
Contributor

@gforcada gforcada commented Sep 7, 2018

Description

See discussion on #11490

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • [] The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@gforcada
Copy link
Contributor Author

gforcada commented Sep 7, 2018

Should this be targeting develop or develop-v6.5 branch? 🤔

@ncoden
Copy link
Contributor

ncoden commented Sep 7, 2018

Hi @gforcada 👋

Thank you for your pull request. I took at look at #11490 and it looks good to me.

It correctly targets develop because it is compatible with the latest version of the code (with breaking changes). Only target develop-v6.5 if your fix is NOT compatible with newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants