Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean submenu items classes in Nest #11467 #11469

Merged

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Aug 22, 2018

Description

When a DropdownMenu (or an other menu with nested items) is destroyed, submenu item classes like is-<type>-submenu-item are not removed, because only direct childs are targeted by the cleaning function.

This pull requests add [data-submenu] > li to ensure that submenu items are cleaned too.

Closes #11467

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@ncoden ncoden added this to the 6.5.0 milestone Aug 22, 2018
@ncoden ncoden requested review from DanielRuf and SassNinja August 23, 2018 21:55
@ncoden ncoden merged commit 0d6f535 into foundation:develop Aug 24, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Aug 25, 2018
…classes-11467 for v6.5.0

fcd02bd fix: clear submenu item classe in Nest foundation#11467

Signed-off-by: Nicolas Coden <[email protected]>
@ncoden ncoden mentioned this pull request Sep 10, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu Destroy method doesn't remove all classes
1 participant