Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix sentence fragment in installation.md #11448

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Conversation

melek
Copy link
Contributor

@melek melek commented Aug 13, 2018

Description

There was a sentence fragment in the Foundation CLI for Foundation 5 users callout. I've attempted to correct the grammar without changing the substance of the section.

No related issue. This is a minor documentation correction.

Motivation and Context

There was a sentence fragment that disrupted reading the docs.

Screenshots (if appropriate):

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • [NA] I have updated the documentation accordingly to my changes (if relevant).
  • [NA] I have added tests to cover my changes (if relevant).
  • [NA] All new and existing tests passed.

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melek 👋,

Thank you for your pull request. This comes from a bad copy/paste when working on #10847.

Your proposal is great, but I'll use the original phrases instead.

@ncoden ncoden merged commit c0a23a8 into foundation:develop Aug 13, 2018
@melek
Copy link
Contributor Author

melek commented Aug 13, 2018

Thanks! Did I submit this properly? I wasn't 100% sure and I haven't worked on Git much before, feedback appreciated.

@ncoden
Copy link
Contributor

ncoden commented Aug 13, 2018

@melek You did everything correctly 👏.

Just one think: give your commit names a contextual name <type>: <description>. So for example: docs: fix Foundation 6 CLI uninstallation note phrasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants