Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: i11443 gulp watch #11444

Merged
merged 2 commits into from
Aug 13, 2018
Merged

fix: i11443 gulp watch #11444

merged 2 commits into from
Aug 13, 2018

Conversation

aorinevo
Copy link
Contributor

Description

When running npm start the project should build, the server should start, and browser should automatically reload on changes.

The serve task blocks the watch task.

Motivation and Context

Without this change, changes made during local development are not automatically seen in the browser.

Screenshots (if appropriate):

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@aorinevo aorinevo force-pushed the I-11443_develop_AN_gulp_fix branch from 3140188 to 674d559 Compare August 12, 2018 15:10
@aorinevo aorinevo force-pushed the I-11443_develop_AN_gulp_fix branch from 674d559 to d0f4054 Compare August 12, 2018 15:13
@ncoden ncoden self-requested a review August 12, 2018 17:56
ncoden
ncoden approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aorinevo, 👋

Thanks a lot of your issue and pull request. I noticed the bug before but did not have the time to investiguate it.

I just looked similar issues in the elsewhere in the codebbase and found the test:reload gulp task. I took care of it. Everything reload well now and the code looks good 🎉. Thanks a lot !

@ncoden ncoden added this to the 6.5.0 milestone Aug 13, 2018
@ncoden ncoden added bug fix and removed bug fix labels Aug 13, 2018
@ncoden ncoden merged commit cf2b6b1 into foundation:develop Aug 13, 2018
@aorinevo aorinevo deleted the I-11443_develop_AN_gulp_fix branch August 13, 2018 22:33
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Aug 25, 2018
@ncoden
Use pull request foundation#11444 from aorinevo/I-11443_develop_AN_gu…
62d7e3e 
…lp_fix for v6.5.0

d0f4054 fix: i11443 gulp watch
c90c048 fix: prevent "test:reload" task to block future reloads

Co-Authored-By: Nicolas Coden <[email protected]>
Signed-off-by: Nicolas Coden <[email protected]>
@ncoden ncoden mentioned this pull request Sep 10, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
🚚 build Gulp
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Gulp serve task blocks watch; browser.reload blocks watch
2 participants
@aorinevo @ncoden