docs: add a notice about required CSS in Media Query doc #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially resolve foundation#11374
4 tasks
DanielRuf
suggested changes
Jul 5, 2018
docs/pages/media-queries.md
Outdated
| @@ -187,6 +187,10 @@ This can be used to combine multiple media queries together. | |||
|
|
|||
| The Foundation JavaScript includes a set of helper functions for working with media queries. They're all on the `Foundation.MediaQuery` object. | |||
|
|
|||
| <div class="callout warning"> | |||
| The MediaQuery utility uses the Sass breakpoints settings and require the Foundation CSS to be imported. For Sass users, you need to include either `foundation-everything()` or `foundation-global-styles()`. | |||
There was a problem hiding this comment.
The MediaQuery utility uses the Sass breakpoint settings and requires the Foundation CSS to be imported. For Sass users, you need to include either foundation-everything() or foundation-global-styles()
|
@DanielRuf I fixed the typo. |
DanielRuf
approved these changes
Jul 5, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 6, 2018
…-styles-notice-11374 for v6.5.0 deee056 docs: add a notice about required CSS in Media Query doc cfcc36b docs: fix typo in Media Query warning about required CSS Signed-off-by: Nicolas Coden <[email protected]>
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 8, 2018
…-styles-notice-11374 for v6.5.0 deee056 docs: add a notice about required CSS in Media Query doc cfcc36b docs: fix typo in Media Query warning about required CSS Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a message in the Media Query documentation to warn that the
MediaQueryhelper require@foundation-global-styles()to have been called.Partially resolve #11374
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).I have added tests to cover my changes (if relevant).