Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on Gutters in the XY Grid doesn't mention the y-axis #11601

Closed
3 tasks done
stuart897 opened this issue Nov 21, 2018 · 2 comments · Fixed by #11610
Closed
3 tasks done

Documentation on Gutters in the XY Grid doesn't mention the y-axis #11601

stuart897 opened this issue Nov 21, 2018 · 2 comments · Fixed by #11610
Labels
📖 documentation PR open XY Grid

Comments

@stuart897
Copy link

Description

Documentation on Gutters in the XY Grid (https://foundation.zurb.com/sites/docs/xy-grid.html#gutters) describes how you can adjust the margin or padding in the x-axis. However, it doesn't explicitly mention there are also classes for adjusting margin/padding in the y-axis too.

Possible Solution

Mention .grid-margin-y and .grid-padding-y in the documentation.

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • here are no other issues similar to this one.
  • The issue title and template are correctly filled.
ncoden added a commit to ncoden/foundation-sites that referenced this issue Nov 26, 2018
@ncoden
docs: document availability of the XY Grid for X/Y/both grids
30601b7 
Closes foundation#11601

Note: this require foundation/foundation-docs#42
@ncoden ncoden mentioned this issue Nov 26, 2018
Merged
9 tasks
@ncoden
Copy link
Contributor

ncoden commented Nov 26, 2018 •
edited
Loading

Hi @stuart897 👋,

Thank you for your issue. I opened the following pull request to improve the documentation of the XY Grid: #11610. Do not hesitate to review it and tell us if you think that anything is missing.

@ncoden ncoden added the PR open label Nov 26, 2018
@stuart897
Copy link
Author

Thanks, looks good. I noticed a minor issue with the commit and left a comment.

@ncoden ncoden mentioned this issue Jan 12, 2019
Merged
11 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📖 documentation PR open XY Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add availability of features in the XY Grid (X/Y/both) ncoden/foundation-sites
3 participants
@DanielRuf @ncoden @stuart897