Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower.json is not valid JSON #11364

Closed
yuriiz opened this issue Jun 30, 2018 · 5 comments · Fixed by #11367
Closed

bower.json is not valid JSON #11364

yuriiz opened this issue Jun 30, 2018 · 5 comments · Fixed by #11367
Labels

Comments

@yuriiz
Copy link

yuriiz commented Jun 30, 2018

https://github.com/zurb/foundation-sites/blob/develop/bower.json in develop branch as of today is not a valid JSON file. There is a syntax error at line #19:

"authors": [
    "ZURB <[email protected]> (http://foundation.zurb.com)",
],

Unlike Javascript, in JSON there can be no comma before ].

@DanielRuf
Copy link
Contributor

Hi @yuriiz,

thanks for reporting this.

Did this break the install for you?

@DanielRuf
Copy link
Contributor

Please see https://github.com/zurb/foundation-sites/blob/support/6.5/bower.json, so this is already addressed in 6.5.0 RC1

@yuriiz
Copy link
Author

yuriiz commented Jun 30, 2018

https://github.com/zurb/foundation-sites/blob/support/6.5/bower.json is 10 days ago.
https://github.com/zurb/foundation-sites/blob/develop/bower.json is 5 days ago.
So I thought it was broken. I'm not sure which version is going to be used in future but it needs to be not the one with error.

ncoden added a commit to ncoden/foundation-sites that referenced this issue Jul 1, 2018
@ncoden
Copy link
Contributor

ncoden commented Jul 1, 2018

Sorry, my bad. My JS lint configuration require a leading , in arrays and objects. So I often keep the habit and make this error when working on JSON files.

Fixed in #11367

@ncoden ncoden added the PR open label Jul 1, 2018
@DanielRuf
Copy link
Contributor

Please see /6.5/bower.json@support, so this is already addressed in 6.5.0 RC1

Wasn't this already done in support/6.5 @ncoden? And I guess you mean trailing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants