Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding v3 SBAFs #90

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Adding v3 SBAFs #90

merged 15 commits into from
Oct 16, 2024

Conversation

salomoneliassonSMHI
Copy link
Collaborator

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest level1c4pps
  • Passes flake8
  • Fully documented

@coveralls
Copy link

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 11367205784

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 51 of 53 (96.23%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 79.725%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/init.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
level1c4pps/gac2pps_lib.py 6 88.16%
Totals Coverage Status
Change from base Build 10386821954: 0.2%
Covered Lines: 1598
Relevant Lines: 1959

💛 - Coveralls

@salomoneliassonSMHI salomoneliassonSMHI marked this pull request as ready for review October 8, 2024 13:48
@BengtRydberg
Copy link
Contributor

BengtRydberg commented Oct 14, 2024

Note that the unit tests in this module level1c4pps/tests/test_gac2pps.py are no longer passing, and must be adapted to the changes in this PR. If you click on details on the rows with a red x below you will see the errors of the test. I guess you mainly need to adapt these tests to changes in name of input parameters.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (9b89b7a) to head (f513c9a).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
level1c4pps/vgac2pps_lib.py 95.45% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   75.75%   77.85%   +2.10%     
==========================================
  Files          23       23              
  Lines        1633     1666      +33     
  Branches      141      146       +5     
==========================================
+ Hits         1237     1297      +60     
+ Misses        360      327      -33     
- Partials       36       42       +6     
Flag Coverage Δ
unittests 77.85% <95.65%> (+2.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ninahakansson
Copy link
Collaborator

Great work with adding all the versions of SBAFs!

@ninahakansson ninahakansson merged commit 5146ff7 into foua-pps:main Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants