Handle some broken time information in VGAC files #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 75.75% 77.51% +1.76%
==========================================
Files 23 23
Lines 1633 1659 +26
Branches 141 163 +22
==========================================
+ Hits 1237 1286 +49
+ Misses 360 330 -30
- Partials 36 43 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9807448556Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle broken time information in VGAC files that are not close to midnight. Some times the time variable (hours since proj_time0) contain unrealistic values ~10**36. This PR makes it possible to ignore if it is not happening directly (with in 100 scanlines) after midnight. Also the time difference between scanlines differ so I am hesitant to use that to more directly calculate the midnight scanline.
pytest level1c4ppsflake8