Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use satpy to rotate SEVIRI images #53

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

sfinkens
Copy link
Collaborator

@sfinkens sfinkens commented Dec 8, 2020

Closes #40

@sfinkens
Copy link
Collaborator Author

Due to merge conflicts I would wait for #50 to be merged before continuing here.

@sfinkens sfinkens self-assigned this Mar 25, 2021
@ninahakansson
Copy link
Collaborator

I just merged #50, is this ready to be merged as well?

@sfinkens
Copy link
Collaborator Author

Yes! I'll resolve the merge conflicts later today.

Conflicts:
	level1c4pps/seviri2pps_lib.py
	level1c4pps/tests/test_seviri2pps.py
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #53 (0b3bdc5) into master (9795e8e) will increase coverage by 0.26%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   76.65%   76.92%   +0.26%     
==========================================
  Files          21       21              
  Lines        1418     1417       -1     
  Branches      110      108       -2     
==========================================
+ Hits         1087     1090       +3     
+ Misses        306      302       -4     
  Partials       25       25              
Flag Coverage Δ
unittests 76.92% <94.11%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
level1c4pps/seviri2pps_lib.py 80.76% <88.23%> (+1.98%) ⬆️
level1c4pps/tests/test_seviri2pps.py 97.37% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9795e8e...0b3bdc5. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 892944262

  • 33 of 34 (97.06%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 77.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/seviri2pps_lib.py 16 17 94.12%
Totals Coverage Status
Change from base Build 892346610: 0.3%
Covered Lines: 1345
Relevant Lines: 1681

💛 - Coveralls

Copy link
Collaborator

@ninahakansson ninahakansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ninahakansson ninahakansson merged commit 104ec07 into foua-pps:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use satpy to rotate SEVIRI image
4 participants