Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to change stream and file log level #6

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

dd-jy
Copy link
Contributor

@dd-jy dd-jy commented May 7, 2021

Change file log level to INFO

Description

(Please describe what this PR do.)
The log file needs to be written more detail information. So please change the file log level to lower level (INFO).

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@dd-jy dd-jy added the chore [PR/Issue] Refactoring, maintenance the code label May 7, 2021
@dd-jy dd-jy requested a review from soimkim May 7, 2021 09:07
@soimkim
Copy link
Contributor

soimkim commented May 7, 2021

Dear @dd-jy ,

fosslight_util supports python 3.6+ and
pathlib is known to be included in the built-in module since Python 3.4.

Should it be included in the requirements.txt?

@dd-jy
Copy link
Contributor Author

dd-jy commented May 10, 2021

It's my mistake. I tested python2.x.
I removed the last commit.

@soimkim
Copy link
Contributor

soimkim commented May 10, 2021

Dear @dd-jy ,

If you want to distribute this to pypi, also upload the commit to upgrade version in setup.py.
And if you release after merge, it is also distributed to pypi.

@dd-jy dd-jy changed the title Change file log level to INFO Add options to change stream and file log level May 12, 2021
@soimkim
Copy link
Contributor

soimkim commented May 12, 2021

@dd-jy , LGTM. :-)

@dd-jy dd-jy merged commit f3292c6 into main May 13, 2021
@dd-jy dd-jy deleted the dd-jy-patch-1 branch May 13, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants