Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spdx for macos #197

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Remove spdx for macos #197

merged 1 commit into from
Oct 15, 2024

Conversation

dd-jy
Copy link
Contributor

@dd-jy dd-jy commented Oct 14, 2024

Description

Remove spdx for macos

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@dd-jy dd-jy added the chore [PR/Issue] Refactoring, maintenance the code label Oct 14, 2024
@dd-jy dd-jy requested a review from soimkim October 14, 2024 05:03
@dd-jy dd-jy self-assigned this Oct 14, 2024
@soimkim
Copy link
Contributor

soimkim commented Oct 14, 2024

@dd-jy , windows와 macOS에서는 spdx-tools를 버전 제한 없이 설치하도록 제안드립니다.
사유: windows와 macOS에서 spdx-tools을 import 에러 방지. (함수를 호출하지 않더라도 해당 함수를 포함한 py를 import하는 경우 import 구문이 호출되어 에러가 날 것으로 추정)

requirements.txt Outdated Show resolved Hide resolved
@dd-jy
Copy link
Contributor Author

dd-jy commented Oct 14, 2024

@soimkim
pyinstaller를 이용하여 windows용 exe 만들때 spdx-tools 최신 버전 포함시 에러가 발생하고 있습니다.
이에 windows인 경우 spdx-tools 설치하지 않도록 제한하였던 것입니다.

현재 제안주신 방법은 scancode-toolkit이 windows와 macos에서 예전 버전으로 fix되어 있어서 해당 버전에서 설치되는 spdx-tools는 에러 발생하지 않을 것으로 보여 수정한것입니다.

함수를 호출하지 않더라도 해당 함수를 포함한 py를 import하는 경우 import 구문이 호출되어 에러가 날 것으로 추정
=> 이에 write_spdx.py에서 해당 import 부분은 try로 묶어두었습니다.

Signed-off-by: jiyeong.seok <[email protected]>
@dd-jy
Copy link
Contributor Author

dd-jy commented Oct 14, 2024

@soimkim
리뷰 후 머지 부탁드립니다~

@soimkim soimkim merged commit fc769a6 into main Oct 15, 2024
4 checks passed
@soimkim soimkim deleted the req_bug branch October 15, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants