Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding external calling function parameter type hints #177

Merged
merged 10 commits into from
Aug 25, 2024

Conversation

MoonJeWoong
Copy link
Contributor

@MoonJeWoong MoonJeWoong commented Aug 3, 2024

Description

Python doesn't provide access modifier, so i added type hints based on the methods called by the ~test.py files run in the tox script. However, the type hints provided by Python do not perform static type checking, so they cannot detect runtime errors in advance. Therefore, I think we can consider introducing static type checking in the next step with a tool like Mypy.
As soon as i'm done with this PR, i'll be doing some research on Mypy.

Related: #170

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Aug 3, 2024
@MoonJeWoong MoonJeWoong marked this pull request as ready for review August 13, 2024 15:32
@soimkim
Copy link
Contributor

soimkim commented Aug 18, 2024

@MoonJeWoong 님, 하기 사항 확인 부탁드립니다.

=================================== FAILURES ===================================
_________________________________ FLAKE8-check _________________________________
/home/runner/work/fosslight_util/fosslight_util/src/fosslight_util/set_log.py:47:131: E501 line too long (157 > 130 characters)

Signed-off-by: MoonJeWoong <[email protected]>
@soimkim soimkim merged commit bed65ac into fosslight:main Aug 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants