Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exhibitor: Add Contact Info column #7736

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

MeghalBisht
Copy link
Member

@MeghalBisht MeghalBisht commented Feb 11, 2021

For: fossasia/open-event-frontend#6649 Point 3

Short description of what this resolves:

added column contact

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #7736 (749a20d) into development (28c8270) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7736   +/-   ##
============================================
  Coverage        67.66%   67.66%           
============================================
  Files              285      285           
  Lines            14320    14322    +2     
============================================
+ Hits              9689     9691    +2     
  Misses            4631     4631           
Impacted Files Coverage Δ
app/api/schema/exhibitors.py 100.00% <100.00%> (ø)
app/models/exhibitor.py 89.28% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c8270...749a20d. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 30c5979 into fossasia:development Feb 12, 2021
@MeghalBisht MeghalBisht deleted the exhibitor-contact branch February 12, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants