fix: updating condition to not show empty session in user section #7465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamareebjamal
changed the title
| @@ -190,7 +190,7 @@ def before_update_object(self, speaker, data, view_kwargs): | |||
| 'Organizer access required to override email', | |||
| ) | |||
| if ( | |||
| data.get('is_email_overridden') | |||
| not data.get('is_email_overridden') | |||
There was a problem hiding this comment.
if email is overriden then there will be no email so email is null m but here are condition that is saying that if email is overriden and email is null then set it to user mail, while it should be, while email is not overriden and email is null set it to user mail
There was a problem hiding this comment.
@maze-runnar You changed this but didn't make email optional in schema
This is causing fossasia/open-event-frontend#5841
There was a problem hiding this comment.
@maze-runnar You changed this but didn't make email optional in schema
This is causing fossasia/open-event-frontend#5841
@iamareebjamal that is related to PR #7469, and I have made email optional but still showing that error.
iamareebjamal
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hout email
Fixes fossasia/open-event-frontend#5342
Checklist
developmentbranch.