Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "withdrawn" and "canceled" speakers and sessions in statistics. #7453

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 17, 2020

Fixes #fossasia/open-event-frontend#5010

required for fossasia/open-event-frontend#5671

Short description of what this resolves:

On the events dashboard at https://eventyay.com/events/live in the speakers and sessions column the status "Withdrawn" and "Canceled" are missing. This PR add them.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #7453 (4ebf12c) into development (393bf7a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7453      +/-   ##
===============================================
- Coverage        65.35%   65.34%   -0.01%     
===============================================
  Files              265      265              
  Lines            13231    13239       +8     
===============================================
+ Hits              8647     8651       +4     
- Misses            4584     4588       +4     
Impacted Files Coverage Δ
app/api/schema/event_statistics.py 65.51% <50.00%> (-2.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393bf7a...4ebf12c. Read the comment docs.

@iamareebjamal iamareebjamal changed the title feat: add "withdrawn" and "canceled" speakers and sessions in Event_statistics. feat: add "withdrawn" and "canceled" speakers and sessions in statistics. Nov 17, 2020
@iamareebjamal iamareebjamal merged commit b0a90f0 into fossasia:development Nov 17, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the fix-5010 branch November 17, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants