Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add weblate_url in settings model #7451

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #fossasia/open-event-frontend#5635

required for this PR fossasia/open-event-frontend#5656

Short description of what this resolves:

Add another option to add a link to Weblate to the Footer.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. I believe the PR title should be modified.

@sachinchauhan2889 sachinchauhan2889 changed the title feature: Footer "Connect with us": Add icon and option for Weblate feature: add weblate_url in settings model Nov 16, 2020
@snitin315
Copy link
Member

feature feat

@sachinchauhan2889 sachinchauhan2889 changed the title feature: add weblate_url in settings model feat: add weblate_url in settings model Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #7451 (3844be1) into development (b56f9c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7451   +/-   ##
============================================
  Coverage        65.34%   65.35%           
============================================
  Files              265      265           
  Lines            13229    13231    +2     
============================================
+ Hits              8645     8647    +2     
  Misses            4584     4584           
Impacted Files Coverage Δ
app/api/schema/settings.py 100.00% <100.00%> (ø)
app/models/setting.py 95.16% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56f9c9...3844be1. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 393bf7a into fossasia:development Nov 16, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the weblate-add branch November 16, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants