-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export custom forms field in csv, pdf for attendee #7444
Conversation
app/templates/pdf/attendees_pdf.html
Outdated
<td><br> | ||
{% for field in custom_forms %} | ||
{% if field.is_complex %}--> | ||
{{ holder.complex_field_values | attr(field.field_identifier) }} {{ holder.complex_field_values | attr(field.field_identifier) }} <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal - Need your help here, how do I apply a condition when the attribute is not present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if field.is_complex and holder.complex_field_values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove -->
from template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O my eyes 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal - Still the values are not fetched by holder.complex_field_values | attr(field.field_identifier)
will check this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@iamareebjamal Tested! Shall I provide you the csv and pdf? |
Yes, and update the screenshots |
And fix the build |
Which one is custom among the fields? |
Github Link, Mobile Can be seen on last 2nd order |
@iamareebjamal Review! |
Codecov Report
@@ Coverage Diff @@
## development #7444 +/- ##
============================================
Coverage 65.28% 65.28%
============================================
Files 265 265
Lines 13223 13237 +14
============================================
+ Hits 8632 8642 +10
- Misses 4591 4595 +4
Continue to review full report at Codecov.
|
Fixes fossasia/open-event-frontend#4615
Short description of what this resolves:
Exported custom forms field in csv, pdf for attendee
Changes proposed in this pull request:
Checklist
development
branch.