fix: Invoice identifier and generation behaviour change #7314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 2, 2020
app/models/event_invoice.py
Outdated
| @@ -119,6 +117,9 @@ def generate_pdf(self): | |||
| if invoice_amount > ticket_fee_maximum: | |||
| invoice_amount = ticket_fee_maximum | |||
| self.amount = round_money(invoice_amount) | |||
| if self.amount == 0: | |||
| logger.warning('Invoice amount of Event %s is 0, hence skipping generation', self.event) | |||
There was a problem hiding this comment.
line too long (104 > 90 characters)
app/models/event_invoice.py
Outdated
| identifier = self.issued_at.strftime('%Y%mU-') + str( | ||
| EventInvoice.query.count() + 1 | ||
| ) | ||
| identifier = self.issued_at.strftime('%Y%mU-') + '%06d' % (EventInvoice.query.count() + 1) |
There was a problem hiding this comment.
line too long (102 > 90 characters)
app/models/event_invoice.py
Outdated
| @@ -62,13 +62,11 @@ def __init__(self, **kwargs): | |||
| self.identifier = self.get_new_id() | |||
|
|
|||
| def __repr__(self): | |||
| return '<EventInvoice %r>' % self.invoice_pdf_url | |||
| return '<EventInvoice %r %r %r>' % (self.id, self.identifier, self.invoice_pdf_url) | |||
app/api/helpers/scheduled_jobs.py
Outdated
| @@ -200,14 +200,16 @@ def send_event_invoice( | |||
| try: | |||
| save_to_db(event_invoice) | |||
| saved = True | |||
| logger.info('Generated Event invoice %s for %s. Amount: %f', event_invoice, event, event_invoice.amount) | |||
There was a problem hiding this comment.
line too long (124 > 90 characters)
Codecov Report
@@ Coverage Diff @@
## development #7314 +/- ##
============================================
Coverage 64.12% 64.12%
============================================
Files 259 259
Lines 13078 13084 +6
============================================
+ Hits 8386 8390 +4
- Misses 4692 4694 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fossasia/open-event-frontend#5211