Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Let event fields be nullable #7251

Merged
merged 2 commits into from
Sep 8, 2020
Merged

fix: Let event fields be nullable #7251

merged 2 commits into from
Sep 8, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 8, 2020

Fixes #7252

@auto-label auto-label bot added the fix label Sep 8, 2020


def get_event(db):
event = EventFactoryBasic(location_name='Amsterdam')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #7251 into development will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7251      +/-   ##
===============================================
+ Coverage        63.02%   63.55%   +0.52%     
===============================================
  Files              259      259              
  Lines            13034    13034              
===============================================
+ Hits              8215     8284      +69     
+ Misses            4819     4750      -69     
Impacted Files Coverage Δ
app/api/events.py 37.50% <ø> (+14.50%) ⬆️
app/api/schema/events.py 96.89% <ø> (+5.29%) ⬆️
app/api/schema/settings.py 100.00% <0.00%> (ø)
app/models/setting.py 94.01% <0.00%> (+0.05%) ⬆️
app/api/helpers/permission_manager.py 58.88% <0.00%> (+0.34%) ⬆️
app/models/user.py 61.79% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8355f9e...58d6add. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previously set fields are not nullable in event
2 participants