Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove soft deletion in roles and role_invites models and schemas #7225

Merged
merged 3 commits into from
Aug 26, 2020
Merged

fix: Remove soft deletion in roles and role_invites models and schemas #7225

merged 3 commits into from
Aug 26, 2020

Conversation

mansiag
Copy link
Contributor

@mansiag mansiag commented Aug 26, 2020

Fixes #7193

Short description of what this resolves:

Role and Role_Invite models do not require soft deletion, so removes soft deletion for these.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 26, 2020
@iamareebjamal iamareebjamal merged commit 4b59625 into fossasia:development Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleted roles/invites in event are not handled correctly
2 participants
@mansiag @iamareebjamal