Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add session mails and notify endpoint #7198

Merged
merged 3 commits into from
Aug 9, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 9, 2020

@auto-label auto-label bot added the feature label Aug 9, 2020
@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #7198 into development will decrease coverage by 0.04%.
The diff coverage is 51.16%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7198      +/-   ##
===============================================
- Coverage        63.02%   62.98%   -0.05%     
===============================================
  Files              259      259              
  Lines            13013    13042      +29     
===============================================
+ Hits              8201     8214      +13     
- Misses            4812     4828      +16     
Impacted Files Coverage Δ
app/api/routes.py 100.00% <ø> (ø)
app/api/helpers/mail.py 25.40% <33.33%> (-0.24%) ⬇️
app/api/sessions.py 57.55% <47.05%> (-1.20%) ⬇️
app/models/helpers/versioning.py 89.28% <50.00%> (-6.72%) ⬇️
app/api/helpers/permission_manager.py 58.53% <57.14%> (+0.14%) ⬆️
app/api/schema/sessions.py 90.24% <66.66%> (-3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f609453...89c9da2. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 761bb3e into development Aug 9, 2020
@iamareebjamal iamareebjamal deleted the session-notify branch August 9, 2020 18:30
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 9, 2020

This pull request fixes 1 alert when merging 89c9da2 into f609453 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Status Change: Send Status Change with Email
1 participant