Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deduplicate get_new_identifier #7182

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

divs4debu
Copy link
Contributor

@divs4debu divs4debu commented Aug 3, 2020

Fixes #7016

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #7182 into development will increase coverage by 0.08%.
The diff coverage is 93.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7182      +/-   ##
===============================================
+ Coverage        62.79%   62.87%   +0.08%     
===============================================
  Files              262      259       -3     
  Lines            13028    12992      -36     
===============================================
- Hits              8181     8169      -12     
+ Misses            4847     4823      -24     
Impacted Files Coverage Δ
app/api/helpers/db.py 96.72% <83.33%> (-1.47%) ⬇️
app/api/helpers/scheduled_jobs.py 47.77% <100.00%> (ø)
app/models/event_invoice.py 95.23% <100.00%> (+1.62%) ⬆️
app/models/order.py 91.54% <100.00%> (+0.75%) ⬆️
app/api/helpers/files.py 73.71% <0.00%> (-1.29%) ⬇️
manage.py 0.00% <0.00%> (ø)
app/api/routes.py 100.00% <0.00%> (ø)
app/api/schema/settings.py 100.00% <0.00%> (ø)
app/models/module.py
app/api/modules.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc2aff...999f7e4. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 856a78d into fossasia:development Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate get_new_identifier
2 participants