fix: Send email when change in session state

[Haider8]

Fixes #7155

Short description of what this resolves:

Email was being sent only when the final session state is accepted or rejected.

Changes proposed in this pull request:

Send email when there's a change in session state.

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[codecov]

Codecov Report

Merging #7157 into development will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development    #7157   +/-   ##
============================================
  Coverage        62.84%   62.85%           
============================================
  Files              262      262           
  Lines            13055    13056    +1     
============================================
+ Hits              8205     8206    +1     
  Misses            4850     4850           

Impacted Files	Coverage Δ
app/api/sessions.py	55.41% <100.00%> (+0.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635bca8...5c68360. Read the comment docs.

[iamareebjamal]

That's even worse. Read the issue again

[Haider8]

We want to send email if there's any change in session details. Then we won't be checking if there's 'state' in data?

[iamareebjamal]

That's the opposite of what we want. Why would we want that? Read the issue again carefully

[iamareebjamal]

This should be written inside the if condition below

[iamareebjamal]

This also does not contain the data.get('send_email') logic

[Haider8]

So below I should write (new_state == 'accepted' or new_state == 'rejected') and data.get('send_email', None) apart from g.send_email?

[iamareebjamal]

Yes

[niranjan94]

Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ app/api/sessions.py  -1
         

See the complete overview on Codacy