feat: Add session custom form validations #7112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 4, 2020
| @@ -4,6 +4,7 @@ | |||
| from app.models.speaker import Speaker | |||
| from tests.factories.speaker import SpeakerSubFactory | |||
| from tests.factories.speakers_call import SpeakersCallSubFactory | |||
| from tests.factories.track import TrackSubFactory | |||
There was a problem hiding this comment.
'tests.factories.track.TrackSubFactory' imported but unused
|
|
||
| data = json.dumps( | ||
| { | ||
| 'data': { |
iamareebjamal
force-pushed
the
session-custom-form
branch
from
5f4b3c8 to
0ec3f7b
Compare
houndci-bot
reviewed
Jul 7, 2020
app/api/helpers/custom_forms.py
Outdated
| @@ -62,11 +64,11 @@ def validate_custom_form_constraints(form, obj): | |||
| return data if data else None | |||
|
|
|||
|
|
|||
| def validate_custom_form_constraints_request(form, schema, obj, data): | |||
| def validate_custom_form_constraints_request(form, schema, obj, data, field_overrides=[]): | |||
There was a problem hiding this comment.
Do not use mutable data structures for argument defaults. They are created during function definition time. All calls to the function reuse this one instance of that data structure, persisting changes between them.
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- app/api/helpers/custom_forms.py 1
- tests/all/integration/api/session/test_session_api.py 8
Complexity decreasing per file
==============================
+ app/api/schema/sessions.py -2
Clones added
============
- tests/all/integration/api/session/test_session_api.py 31
See the complete overview on Codacy |
niranjan94
reviewed
Jul 7, 2020
| assert session.language is None | ||
|
|
||
|
|
||
| def test_custom_form_create_complex_fields_missing_required(db, client, user, jwt): |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## development #7112 +/- ##
===============================================
+ Coverage 62.51% 62.80% +0.28%
===============================================
Files 262 262
Lines 13004 13005 +1
===============================================
+ Hits 8130 8168 +38
+ Misses 4874 4837 -37
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7116
Fixes #7074