Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore non-included form fields in complex form #7081

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jun 26, 2020

Fixes #7074

@auto-label auto-label bot added the feature label Jun 26, 2020
attrs = {}

for field in form_fields:
if field.type in ['text', 'checkbox', 'select']:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/api/helpers/custom_forms.py  2
- tests/all/integration/api/attendee/test_attendee_api.py  2
         

Clones added
============
- tests/all/integration/api/attendee/test_attendee_api.py  3
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #7081 into development will increase coverage by 0.03%.
The diff coverage is 88.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7081      +/-   ##
===============================================
+ Coverage        61.92%   61.95%   +0.03%     
===============================================
  Files              262      262              
  Lines            12960    12981      +21     
===============================================
+ Hits              8025     8043      +18     
- Misses            4935     4938       +3     
Impacted Files Coverage Δ
app/api/helpers/custom_forms.py 93.33% <87.50%> (-6.67%) ⬇️
app/api/attendees.py 49.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7411867...d20a153. Read the comment docs.

@iamareebjamal iamareebjamal merged commit cd347b5 into development Jun 26, 2020
@iamareebjamal iamareebjamal deleted the custom-form/complex-ignore branch June 26, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom form complex field validation
3 participants