Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Normalize custom form fields to snake case #7078

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jun 25, 2020

Fix for #7074

@auto-label auto-label bot added the feature label Jun 25, 2020
test_data_first = 'attachment; filename="image.png"'
test_data_none = None
expected_response_first = ('"image', '.png"')
expected_response_none = ('', '')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/all/unit/api/helpers/test_utilities.py  9
- app/api/helpers/fields.py  1
         

Clones removed
==============
+ tests/all/integration/api/attendee/test_attendee_api.py  -2
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #7078 into development will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7078      +/-   ##
===============================================
+ Coverage        61.86%   61.92%   +0.06%     
===============================================
  Files              261      262       +1     
  Lines            12940    12961      +21     
===============================================
+ Hits              8005     8026      +21     
  Misses            4935     4935              
Impacted Files Coverage Δ
app/api/helpers/custom_forms.py 100.00% <ø> (ø)
app/api/helpers/fields.py 100.00% <100.00%> (ø)
app/api/helpers/utilities.py 73.07% <100.00%> (+4.42%) ⬆️
app/api/schema/attendees.py 100.00% <100.00%> (ø)
app/api/schema/sessions.py 87.65% <100.00%> (+0.15%) ⬆️
app/api/schema/speakers.py 97.87% <100.00%> (+0.04%) ⬆️
app/models/custom_form.py 98.00% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7950499...dbdca2d. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 25, 2020

This pull request introduces 1 alert when merging da21129 into 7950499 - view on LGTM.com

new alerts:

  • 1 for Unused import

@iamareebjamal iamareebjamal merged commit a081fe6 into development Jun 25, 2020
@iamareebjamal iamareebjamal deleted the custom-form/complex-snake branch June 25, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants