feat: Add complex custom form validations #7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 23, 2020
|
|
||
| if len(missing_required_fields) > 0: | ||
| raise UnprocessableEntityError( | ||
| {'pointer': '/data/attributes'}, |
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- app/api/helpers/custom_forms.py 7
Complexity decreasing per file
==============================
+ tests/all/integration/api/attendee/test_attendee_api.py -5
Clones added
============
- tests/all/integration/api/attendee/test_attendee_api.py 9
See the complete overview on Codacy |
niranjan94
reviewed
Jun 23, 2020
| assert attendee.complex_field_values is None | ||
|
|
||
|
|
||
| def test_custom_form_complex_fields_missing_required_one(db, client, jwt): |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## development #7073 +/- ##
===============================================
+ Coverage 61.81% 61.86% +0.04%
===============================================
Files 260 261 +1
Lines 12929 12940 +11
===============================================
+ Hits 7992 8005 +13
+ Misses 4937 4935 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7074