Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add OS support in README #6990

Merged
merged 4 commits into from
May 11, 2020

Conversation

sanjana-302
Copy link
Contributor

Fixes #6989

Short description of what this resolves:

Operating systems that are suitable for running the application have been mentioned in the README.md file itself. This will help the people who are new, to set up their system accordingly.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@iamareebjamal iamareebjamal requested a review from prateekj117 May 11, 2020 14:37
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #6990 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6990   +/-   ##
============================================
  Coverage        59.82%   59.82%           
============================================
  Files              259      259           
  Lines            12875    12875           
============================================
  Hits              7702     7702           
  Misses            5173     5173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e87d1...ed6b28d. Read the comment docs.

README.md Outdated
**NOTE :** If you are heading towards Local Installation, Be sure that you use one of the following operating systems :


* Debian based Linux Distribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Should we also add a recommendation for Debian version to be 10, as in the README, we have the command sudo apt-get install python3.7 which will fail in Debian 9 as python3.7 is not available as a package in Debian 9.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most people use Ubuntu and don't know what's debian. So it should be Debian based Linux Distros (like Ubuntu) and no, we discourage using apt to install python because it will be always stuck with the distribution itself. Using pyenv is recommended as previously discussed. However, python installation is not the scope of this issue AFAIK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Agree. @sanjana-302 Please make the following changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal @prateekj117 Thank you for suggestions. I will make mentioned changes.

Copy link
Member

@prateekj117 prateekj117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use semantic naming in PR title. See other PRs for reference.

README.md Outdated
@@ -40,6 +40,13 @@ A demo version is automatically deployed from our repositories:

The Open Event Server can be easily deployed on a variety of platforms. Detailed platform-specific installation instructions have been provided below.


**NOTE :** If you are heading towards Local Installation, Be sure that you use one of the following operating systems :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**NOTE :** If you are heading towards Local Installation, Be sure that you use one of the following operating systems :
**NOTE:** If you are heading towards `Local Installation`, be sure to use one of the following operating systems:

README.md Outdated


* Debian based Linux Distros (like Ubuntu)
* Macintosh Operating System
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Macintosh Operating System
* MacOS

@sanjana-302 sanjana-302 changed the title Added OS support in README.md chore(docs): Add OS support in README May 11, 2020
@auto-label auto-label bot added the docs label May 11, 2020
@sanjana-302
Copy link
Contributor Author

Use semantic naming in PR title. See other PRs for reference.

Okay.

@sanjana-302 sanjana-302 requested a review from prateekj117 May 11, 2020 19:42
@iamareebjamal iamareebjamal merged commit ef7dbac into fossasia:development May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify OS supported in README
3 participants