Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use nested transactions for all tests #6981

Merged
merged 1 commit into from
May 8, 2020

Conversation

iamareebjamal
Copy link
Member

  • Create legacy test case for breaking cases
  • Use proxy for db session
  • Test time reduced to 25 sec

TODO:

  • Fix factory ID sequence reset
  • Add nested transactions in dredd tests

assert notification.title == 'Invitation to be Dinosaur at Mass Extinction'
assert (
notification.message
== "You've been invited to be one of the <strong>Dinosaurs</strong> at <strong>Mass Extinction</strong>."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (113 > 90 characters)

assert notification.title == 'Session Homeless Therapy has been accepted'
assert (
notification.message
== 'The session <strong>Homeless Therapy</strong> has been <strong>accepted</strong> '

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (94 > 90 characters)

if __name__ == '__main__':
unittest.main()

link = 'https://test.link'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@iamareebjamal iamareebjamal changed the title chore: Use nested transactions for all tests test: Use nested transactions for all tests May 7, 2020
@auto-label auto-label bot added the testing label May 7, 2020
@auto-label auto-label bot added chore and removed testing labels May 7, 2020
- Create legacy test case for breaking cases
- Use proxy for db session
- Test time reduced to 25 sec

TODO:
- Fix factory ID sequence reset
- Add nested transactions in dredd tests
@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/all/integration/api/helpers/test_notification.py  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #6981 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6981   +/-   ##
============================================
  Coverage        60.87%   60.87%           
============================================
  Files              259      259           
  Lines            13564    13564           
============================================
  Hits              8257     8257           
  Misses            5307     5307           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6554b0...90be03a. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 89d5198 into fossasia:development May 8, 2020
@iamareebjamal iamareebjamal deleted the scoped branch May 8, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants