Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow old dates in patch request #6915

Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix: Allow old dates in patch request #6915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/api/schema/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ class Meta:

@validates_schema(pass_original=True)
def validate_fields(self, data, original_data):
if 'id' in original_data['data']:
is_patch_request = 'id' in original_data['data']
if is_patch_request:
try:
session = Session.query.filter_by(id=original_data['data']['id']).one()
except NoResultFound:
Expand All @@ -54,9 +55,9 @@ def validate_fields(self, data, original_data):
{'pointer': '/data/attributes/ends-at'},
"ends-at should be after starts-at",
)
if datetime.timestamp(data['starts_at']) <= datetime.timestamp(
datetime.now()
):
if not is_patch_request and datetime.timestamp(
data['starts_at']
) <= datetime.timestamp(datetime.now()):
raise UnprocessableEntity(
{'pointer': '/data/attributes/starts-at'},
"starts-at should be after current date-time",
Expand Down