-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Addition of is_promoted field in event #6755
Conversation
Codecov Report
@@ Coverage Diff @@
## development #6755 +/- ##
============================================
Coverage 65.41% 65.41%
============================================
Files 300 300
Lines 15340 15340
============================================
Hits 10034 10034
Misses 5306 5306
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between featured and promoted here?
None in server side, On FE promoted events will be shown before the general events in the list of upcoming events as requested in the issue. |
@iamareebjamal Please check! |
The frontend should not just show promoted events but it should show promoted events first |
This field will be needed anyway.
…On Sun, 19 Jan, 2020, 19:57 Areeb Jamal, ***@***.***> wrote:
The frontend should not just show promoted events but it should show
promoted events first
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6755?email_source=notifications&email_token=AKQMTLS5EUJNH5DCVREG6G3Q6RPMDA5CNFSM4KISXFI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKTOYQ#issuecomment-576010082>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLVCAWTCOLRS4F7H34LQ6RPMDANCNFSM4KISXFIQ>
.
|
More changes will be needed on server if the behaviour is to be carried out |
Can't we just query these events before the other while rendering on FE?
…On Sun, 19 Jan, 2020, 20:17 Areeb Jamal, ***@***.***> wrote:
More changes will be needed on server if the behaviour is to be carried out
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6755?email_source=notifications&email_token=AKQMTLQIOZQAGK4LTP4NI5DQ6RRX5A5CNFSM4KISXFI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKT5II#issuecomment-576011937>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLV7D2XUQ3IQGXRZK2TQ6RRX5ANCNFSM4KISXFIQ>
.
|
OK |
Refers fossasia/open-event-frontend#3658