Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Addition of is_promoted field in event #6755

Merged
merged 3 commits into from
Jan 19, 2020

Conversation

kushthedude
Copy link
Member

@auto-label auto-label bot added the feature label Jan 18, 2020
@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #6755 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6755   +/-   ##
============================================
  Coverage        65.41%   65.41%           
============================================
  Files              300      300           
  Lines            15340    15340           
============================================
  Hits             10034    10034           
  Misses            5306     5306
Impacted Files Coverage Δ
app/api/helpers/system_mails.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d641d4c...3dd80c4. Read the comment docs.

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between featured and promoted here?

@kushthedude
Copy link
Member Author

What's the difference between featured and promoted here?

None in server side, On FE promoted events will be shown before the general events in the list of upcoming events as requested in the issue.

@kushthedude
Copy link
Member Author

@iamareebjamal Please check!

@iamareebjamal
Copy link
Member

The frontend should not just show promoted events but it should show promoted events first

@kushthedude
Copy link
Member Author

kushthedude commented Jan 19, 2020 via email

@iamareebjamal
Copy link
Member

More changes will be needed on server if the behaviour is to be carried out

@kushthedude
Copy link
Member Author

kushthedude commented Jan 19, 2020 via email

@iamareebjamal
Copy link
Member

OK

@iamareebjamal iamareebjamal merged commit 0ccf18c into fossasia:development Jan 19, 2020
@kushthedude kushthedude deleted the front branch January 22, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants