Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): Remove versions model file #6739

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

codedsun
Copy link
Contributor

Fixes #6738

Changes proposed in this pull request:

  • Removed version model

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #6739 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #6739   +/-   ##
===========================================
  Coverage         65.4%   65.4%           
===========================================
  Files              300     300           
  Lines            15322   15322           
===========================================
  Hits             10021   10021           
  Misses            5301    5301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b724b4...2d8708a. Read the comment docs.

@codedsun
Copy link
Contributor Author

@iamareebjamal -Review!

@codedsun
Copy link
Contributor Author

@iamareebjamal - chck this

@iamareebjamal
Copy link
Member

You sure it is not being used?

@iamareebjamal
Copy link
Member

Where's the migration to delete the table

@codedsun
Copy link
Contributor Author

@iamareebjamal - How do i create the migration when it's not present in my DB. I ran python3 manage.py db migrate

It says INFO [alembic.env] No changes in schema detected.

@codedsun
Copy link
Contributor Author

@iamareebjamal - Also it was created here

op.create_table('versions',

and dropped here

@codedsun
Copy link
Contributor Author

codedsun commented Jan 15, 2020

@iamareebjamal - Please check the comment again #6739 (comment)

@iamareebjamal iamareebjamal changed the title fix: Remove versions model file chore(refactor): Remove versions model file Jan 15, 2020
@iamareebjamal iamareebjamal merged commit c88dd7d into fossasia:development Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove version model
3 participants