Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Order Post route view #6683

Merged
merged 2 commits into from
Dec 21, 2019

Conversation

prateekj117
Copy link
Member

Fixes #6673

Short description of what this resolves:

#6679 was a workaround.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@prateekj117
Copy link
Member Author

@mariobehling @kushthedude Please review.

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #6683 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6683   +/-   ##
============================================
  Coverage        65.34%   65.34%           
============================================
  Files              300      300           
  Lines            15258    15258           
============================================
  Hits              9971     9971           
  Misses            5287     5287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9202d6e...bd3c2de. Read the comment docs.

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iamareebjamal iamareebjamal changed the title fix: Order Post route broken fix: Order Post route view Dec 21, 2019
@iamareebjamal iamareebjamal merged commit d836d0f into fossasia:development Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My-Ticket route is broken.
3 participants