Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Correct API docs for update order #6546

Merged
merged 2 commits into from
Oct 23, 2019
Merged

chore(docs): Correct API docs for update order #6546

merged 2 commits into from
Oct 23, 2019

Conversation

Tlazypanda
Copy link
Contributor

Fixes #6451

Short description of what this resolves:

The PATCH request for orders API docs shows identifier instead of the id as the value of id in body of the request, which actually shows an error when used.

Changes proposed in this pull request:

  • Api docs corrected replacing identifier with id.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #6546 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6546   +/-   ##
============================================
  Coverage        65.12%   65.12%           
============================================
  Files              296      296           
  Lines            15292    15292           
============================================
  Hits              9959     9959           
  Misses            5333     5333

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e6bfa...e6b3df7. Read the comment docs.

@prateekj117
Copy link
Member

@iamareebjamal I think it's good to merge.

@iamareebjamal
Copy link
Member

@prateekj117 What's the difference between this and #6462

@prateekj117
Copy link
Member

@iamareebjamal The tests were failing last time I checked that PR. And @mrsaicharan1 also commented on that regarding the same. My fault I didn't saw the file changes, they are right. No idea why the tests were failing then.

@iamareebjamal
Copy link
Member

No other place requires changes?

@prateekj117
Copy link
Member

I think.

@iamareebjamal iamareebjamal changed the title Correct api docs for update order chore: Correct API docs for update order Oct 23, 2019
@auto-label auto-label bot added the chore label Oct 23, 2019
@iamareebjamal iamareebjamal changed the title chore: Correct API docs for update order chore(docs): Correct API docs for update order Oct 23, 2019
@auto-label auto-label bot added docs and removed chore labels Oct 23, 2019
@iamareebjamal iamareebjamal merged commit dfa6bb8 into fossasia:development Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct API docs of update orders
3 participants