chore: Remove populate and fix various dredd tests #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #6506 +/- ##
===============================================
+ Coverage 64.53% 64.54% +0.01%
===============================================
Files 292 292
Lines 15140 15142 +2
===============================================
+ Hits 9771 9774 +3
+ Misses 5369 5368 -1
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Oct 5, 2019
| @@ -338,8 +339,7 @@ def event_post(transaction): | |||
| :return: | |||
| """ | |||
| with stash['app'].app_context(): | |||
| event = EventFactoryBasic() | |||
| db.session.add(event) | |||
| RoleFactory(name=OWNER) # TODO: Change to get_or_create in event after_created | |||
There was a problem hiding this comment.
at least two spaces before inline comment
| @@ -11,6 +11,7 @@ | |||
| from flask_migrate import Migrate, stamp | |||
| from flask import Flask | |||
| from app.models import db | |||
| from app.models.user import OWNER | |||
There was a problem hiding this comment.
module level import not at top of file
houndci-bot
reviewed
Oct 5, 2019
| @@ -8,10 +8,10 @@ | |||
| # placed only below this | |||
| sys.path.insert(1, path.abspath(path.join(__file__, "../.."))) | |||
|
|
|||
| from flask_migrate import Migrate, stamp | |||
| from flask_migrate import Migrate | |||
There was a problem hiding this comment.
module level import not at top of file
| @@ -14,3 +15,9 @@ def test_migrations(self): | |||
| with app.test_request_context(): | |||
| result = check_migrations().split(',') | |||
| self.assertEqual(result[0], 'success') | |||
|
|
|||
iamareebjamal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.