New UI #733
Merged
New UI #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughЭтот набор изменений в основном затрагивает обновление путей к ресурсам интерфейса и иконок в проекте SpaceCats. Изменения включают добавление новых действий, связанных с критическим состоянием, обновление путей к спрайтам для множества предупреждений, а также модификацию цветовой схемы темы по умолчанию. Также были добавлены новые метаданные для различных ресурсов интерфейса, перемещенных в новую директорию Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
RSI Diff Bot; head commit 5bd4e8d merging into b290b34 Resources/Textures/Interface/Alerts/mood.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/battery.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/borg_critical.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/borg_dead.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/crawling.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/ensnared.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/human_critical.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/human_dead.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/hunger.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/internals.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/pacified.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi
Resources/Textures/_SpaceCats/Interface/Alerts/thirst.rsi
Resources/Textures/_SpaceCats/Interface/actions_crit.rsi
Resources/Textures/_SpaceCats/Mobs/Species/Human/organs.rsi
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🔭 Outside diff range comments (2)
Resources/Prototypes/_Backmen/Alerts/shadowkin.yml (1)
Обнаружены зависимости от удаляемой категории оповещений
Анализ показал, что категория
ShadowkinPowerиспользуется в двух местах:
- В
Resources/Prototypes/_Backmen/Alerts/shadowkin.yml- определение самой категории и оповещения, использующего её- В
Resources/Prototypes/Alerts/alerts.yml- категория используется в списке системных оповещенийПеред удалением категории
ShadowkinPowerнеобходимо:
- Удалить или обновить соответствующую запись в
Resources/Prototypes/Alerts/alerts.yml- Убедиться, что все оповещения, использующие эту категорию, либо удалены, либо переведены на другую категорию
🔗 Analysis chain
Line range hint
1-3: Проверьте влияние удаления категории оповещенийУдаление
alertCategoryс идентификаторомShadowkinPowerможет повлиять на другие части системы, которые зависят от этой категории.Выполните следующий скрипт для поиска зависимостей:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Поиск использования категории ShadowkinPower в кодовой базе rg -l "ShadowkinPower" --type yamlLength of output: 124
Script:
#!/bin/bash # Проверим содержимое файлов, где используется ShadowkinPower rg "ShadowkinPower" -C 5 --type yamlLength of output: 1644
🧰 Tools
🪛 GitHub Actions: YAML Linter
[error] File not found. (/Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi/meta.json)
Resources/Prototypes/Actions/crit.yml (1)
Line range hint
34-47: Ограничение длины последних словВ описании указано ограничение в 30 символов, но это ограничение не реализовано в самом действии. Необходимо добавить валидацию.
- type: InstantAction itemIconStyle: NoItem checkCanInteract: false checkConsciousness: false icon: sprite: _SpaceCats/Interface/actions_crit.rsi state: lastwords event: !type:CritLastWordsEvent + maxLength: 30 startDelay: true useDelay: 10
🧹 Nitpick comments (5)
Resources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/meta.json (1)
11-43: Оптимизируйте определение задержек анимацииТекущая реализация содержит избыточное повторение одинаковых значений задержки (0.05) для каждого состояния здоровья. Рекомендуется упростить структуру.
Предлагаемые изменения:
"name": "health0", "delays": [ - [ - 0.05, - 0.05, - ... // множество повторений - 0.05 - ] + [0.05] ]Такое изменение следует применить ко всем состояниям здоровья. RSI формат поддерживает циклическое повторение одного значения задержки.
Also applies to: 46-78, 81-113, 116-148, 151-183
Resources/Prototypes/_Backmen/Alerts/shadowkin.yml (1)
8-20: Рассмотрите возможность оптимизации повторяющегося кодаВ текущей реализации путь к спрайту повторяется для каждого состояния power0-power7. Рекомендуется использовать общий путь к спрайту на уровне определения оповещения.
Предлагаемая структура:
- type: alert id: ShadowkinPower category: ShadowkinPower sprite: /Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi icons: - state: power0 - state: power1 # ... остальные состояния🧰 Tools
🪛 GitHub Actions: YAML Linter
[error] File not found. (/Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi/meta.json)
Resources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/meta.json (1)
11-40: Оптимизируйте определение задержек анимацииТекущая реализация использует повторяющиеся значения в массивах задержек. Можно упростить структуру, используя одно значение вместо повторяющихся.
Пример оптимизации для одного состояния:
{ "name": "power0", - "delays": [[0.8, 0.8, 0.8, 0.8, 0.8, 0.8]] + "delays": [[0.8]] }Resources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/meta.json (1)
14-51: Оптимизация анимацииСостояния stamina5, stamina4 и stamina3 имеют идентичные задержки. Рекомендуется использовать общий шаблон анимации для оптимизации.
{ "name": "stamina5", "delays": [[0.5, 0.2, 0.2, 0.2, 0.2, 0.5]] }, { "name": "stamina4", - "delays": [[0.5, 0.2, 0.2, 0.2, 0.2, 0.5]] + "baseState": "stamina5" }, { "name": "stamina3", - "delays": [[0.5, 0.2, 0.2, 0.2, 0.2, 0.5]] + "baseState": "stamina5" }Resources/Prototypes/themes.yml (1)
Line range hint
19-101: Отключение альтернативных темКомментирование альтернативных тем может негативно повлиять на пользовательский опыт. Рекомендуется:
- Сохранить возможность выбора темы
- Обновить существующие темы в соответствии с новым стилем
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (160)
Resources/Textures/Interface/Alerts/mood.rsi/mood1.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood2.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood3.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood4.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood5.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood6.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood7.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood8.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood9.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood_happiness_bad.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood_happiness_good.pngis excluded by!**/*.pngResources/Textures/Interface/Alerts/mood.rsi/mood_insane.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Actions/harm.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Actions/harmOff.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Abilities/silenced.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Buckle/buckled.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Fire/fire.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Handcuffed/Handcuffed.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Pull/pulled.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Pull/pulling.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/Weightless/weightless.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery-none.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery10.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery4.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery5.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery6.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery7.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery8.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/battery9.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed10.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed4.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed5.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed6.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed7.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed8.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/bleed9.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/health0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/health1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/health2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/health3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/health4.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_critical.rsi/critical.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/borg_dead.rsi/dead.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/not_enough_co2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/not_enough_nitro.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/not_enough_oxy.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/not_enough_tox.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/too_much_co2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/too_much_nitro.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/too_much_oxy.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/too_much_tox.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/crawling.rsi/crawling.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/ensnared.rsi/ensnared.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/health0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/health1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/health2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/health3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/health4.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_critical.rsi/critical.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/human_dead.rsi/dead.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/hunger.rsi/overfed.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/hunger.rsi/peckish.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/hunger.rsi/starving.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/internals.rsi/internal0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/internals.rsi/internal1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/internals.rsi/internal2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/pacified.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/piloting.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi/highpressure1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi/highpressure2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi/lowpressure1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi/lowpressure2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power4.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power5.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power6.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/power7.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina0.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina4.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina5.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/stamina6.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/cold1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/cold2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/cold3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/hot1.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/hot2.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/hot3.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/thirst.rsi/overhydrated.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/thirst.rsi/parched.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/Alerts/thirst.rsi/thirsty.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/SlotBackground.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/avaliears.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/back.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/belt.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/ears.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/ears_headset.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/glasses.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/gloves.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/hand_l.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/hand_l_no_letter.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/hand_m.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/hand_r.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/hand_r_no_letter.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/head.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/id.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/mask.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/neck.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/pants.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/pda.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/pocket.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/shoes.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/socks.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/suit.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/suit_storage.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/tailbag.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/template.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/toggle.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/underpants.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/undershirt.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/uniform.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Slots/web.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/back.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/exit.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_bottom.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_bottomLeft.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_bottomRight.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_center.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_left.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_right.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_top.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_topLeft.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/piece_topRight.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/sidebar_bottom.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/sidebar_fat.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/sidebar_mid.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/Storage/sidebar_top.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/item_status_left.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/item_status_left_highlight.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/item_status_right.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/item_status_right_highlight.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/slot_highlight.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/target_doll.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/CatsUI/template_small.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/actions_crit.rsi/fakedeath.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Interface/actions_crit.rsi/lastwords.pngis excluded by!**/*.pngResources/Textures/_SpaceCats/Mobs/Species/Human/organs.rsi/heart-off.pngis excluded by!**/*.png
📒 Files selected for processing (26)
Resources/Prototypes/Actions/crit.yml(2 hunks)Resources/Prototypes/Actions/types.yml(1 hunks)Resources/Prototypes/Alerts/alerts.yml(19 hunks)Resources/Prototypes/_Backmen/Alerts/shadowkin.yml(1 hunks)Resources/Prototypes/themes.yml(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/borg_critical.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/borg_dead.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/crawling.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/ensnared.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/human_critical.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/human_dead.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/hunger.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/internals.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/pacified.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/Alerts/thirst.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Interface/actions_crit.rsi/meta.json(1 hunks)Resources/Textures/_SpaceCats/Mobs/Species/Human/organs.rsi/meta.json(1 hunks)
✅ Files skipped from review due to trivial changes (20)
- Resources/Textures/_SpaceCats/Interface/Alerts/human_critical.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/internals.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/actions_crit.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/borg_dead.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/borg_critical.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/thirst.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/bleed.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/battery.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/temperature.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/breathing.rsi/meta.json
- Resources/Prototypes/Actions/types.yml
- Resources/Textures/_SpaceCats/Interface/Alerts/human_dead.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/hunger.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/pressure.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/borg_alive.rsi/meta.json
- Resources/Textures/_SpaceCats/Mobs/Species/Human/organs.rsi/meta.json
- Resources/Prototypes/Alerts/alerts.yml
- Resources/Textures/_SpaceCats/Interface/Alerts/ensnared.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/crawling.rsi/meta.json
- Resources/Textures/_SpaceCats/Interface/Alerts/pacified.rsi/meta.json
🧰 Additional context used
🪛 GitHub Actions: YAML Linter
Resources/Prototypes/_Backmen/Alerts/shadowkin.yml
[error] File not found. (/Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi/meta.json)
🔇 Additional comments (3)
Resources/Textures/_SpaceCats/Interface/Alerts/human_alive.rsi/meta.json (1)
9-185: Проверьте соответствие состояний здоровья игровой механикеВ файле определено 5 состояний здоровья (health0-health4). Необходимо убедиться, что:
- Количество состояний соответствует игровой механике
- Названия состояний соответствуют конвенциям проекта
- Порядок состояний логичен (health0 = критическое, health4 = полное здоровье)
✅ Verification successful
Let me analyze the results from the shell scripts. I can see that:
- The health states (health0-health4) are consistently used across multiple interface files including human_alive.rsi, borg_alive.rsi, and human_crew_monitoring.rsi
- These states are referenced in alerts.yml with proper descriptions
- The convention appears to be consistent across the codebase
Let me generate the final response in Russian:
Состояния здоровья соответствуют игровой механике
Проверка показала, что:
- Количество состояний (5 уровней от health0 до health4) является стандартным для проекта
- Названия состояний соответствуют принятым конвенциям, что подтверждается их использованием в других файлах интерфейса
- Порядок состояний логичен: health0 для критического состояния, health4 для полного здоровья
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Поиск использования состояний здоровья в коде rg -A 2 "health[0-4]" # Поиск других RSI файлов для сравнения конвенций именования fd -e rsi -x cat {}/meta.jsonLength of output: 70127
Resources/Prototypes/Actions/crit.yml (1)
28-28: Проверка существования спрайтовНеобходимо убедиться, что файл
_SpaceCats/Interface/actions_crit.rsiсуществует и содержит все необходимые состояния (fakedeath,lastwords).Also applies to: 43-43
✅ Verification successful
Спрайты найдены и содержат необходимые состояния
Файл
_SpaceCats/Interface/actions_crit.rsiсуществует в директорииResources/Texturesи содержит все требуемые состояния:
lastwordsfakedeathПуть к спрайтам корректен и все необходимые состояния присутствуют в файле.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the RSI file and states exist fd -e rsi "actions_crit.rsi" | while read -r file; do if [ -f "$file/meta.json" ]; then echo "Found RSI file: $file" jq '.states[].name' "$file/meta.json" fi doneLength of output: 765
Resources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/meta.json (1)
3-4: Проверка лицензии и авторских правНеобходимо проверить:
- Соответствует ли лицензия CC-BY-SA-3.0 оригинальному проекту DeltaV-Stray
- Правильно ли указано авторство NES-Station
✅ Verification successful
Лицензия и авторские права подтверждены
Анализ показывает, что указанная лицензия CC-BY-SA-3.0 и авторство NES-Station (Aserovich) являются корректными. Эти же атрибуты последовательно используются в других файлах интерфейса и машин из того же набора ресурсов _SpaceCats, что подтверждает их легитимность.
• Файл является частью большой коллекции ресурсов с одинаковыми атрибутами авторства
• Найдено более 20 других файлов с тем же автором и лицензией
• Все файлы находятся в согласованной структуре каталогов _SpaceCats🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for license information in the original project gh api repos/EndrAnimet/DeltaV-Stray/contents | jq -r '.[] | select(.name | test("LICENSE|license")) | .name'Length of output: 146
Script:
#!/bin/bash # Check content of both license files gh api repos/EndrAnimet/DeltaV-Stray/contents/LICENSE-AGPLv3.txt | jq -r '.content' | base64 -d echo "---" gh api repos/EndrAnimet/DeltaV-Stray/contents/LICENSE-MIT.txt | jq -r '.content' | base64 -dLength of output: 397
Script:
#!/bin/bash # Search for any mentions of NES-Station or Aserovich in the repository rg -i "nes-station|aserovich" --type-add 'meta:*.json' -g '*.md' -g '*.txt' -g 'meta:*.json'Length of output: 94
Script:
#!/bin/bash # Check if there are other similar RSI files with copyright information fd -e json -x grep -l "copyright\|license" {}Length of output: 65633
Script:
#!/bin/bash # Check content of stamina RSI file cat Resources/Textures/_SpaceCats/Interface/Alerts/stamina.rsi/meta.jsonLength of output: 1854
Script:
#!/bin/bash # Search for any other files with similar copyright/license info rg -l "NES-Station|Aserovich" Resources/Textures/_SpaceCats/Length of output: 1735
Comment on lines
3
to
4
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "NES-Station, created by Aserovich", |
There was a problem hiding this comment.
💡 Codebase verification
Обнаружено несоответствие лицензий и авторских прав
Анализ показывает серьёзные проблемы с лицензированием:
- Исходный проект DeltaV-Stray использует лицензию AGPL-3.0
- В файлах текстур указана лицензия CC-BY-SA-3.0
- Авторство приписано "NES-Station, created by Aserovich", что не соответствует источнику спрайтов
Необходимо:
- Привести лицензию в соответствие с AGPL-3.0 исходного проекта
- Указать корректное авторство из проекта DeltaV-Stray
- Добавить ссылку на оригинальный репозиторий
🔗 Analysis chain
Проверьте атрибуцию авторских прав
Согласно описанию PR, спрайты портированы из проекта DeltaV-Stray, однако в метаданных указан другой источник (NES-Station). Необходимо убедиться, что:
- Лицензия CC-BY-SA-3.0 соответствует лицензии исходного проекта
- Указание авторства корректно отражает источник спрайтов
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Проверка лицензии в исходном проекте
gh repo view EndrAnimet/DeltaV-Stray --json licenseInfo
Length of output: 164
Script:
#!/bin/bash
# Search for similar texture files and their metadata
fd "meta.json" Resources/Textures/_SpaceCats/Interface/Alerts/ -x cat {}
Length of output: 12687
| state: power6 | ||
| - sprite: /Textures/Backmen/Interface/Alerts/shadowkin_power.rsi | ||
| - sprite: /Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi # Cats edit |
There was a problem hiding this comment.
Исправьте опечатку в пути к спрайту power7
В пути к спрайту для состояния power7 обнаружена опечатка: _SpaceCatsI/nterface вместо _SpaceCats/Interface. Это вызывает ошибку сборки.
Примените следующее исправление:
- sprite: /Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi # Cats edit
+ sprite: /Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi # Cats edit📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - sprite: /Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi # Cats edit | |
| - sprite: /Textures/_SpaceCats/Interface/Alerts/shadowkin_power.rsi # Cats edit |
🧰 Tools
🪛 GitHub Actions: YAML Linter
[error] File not found. (/Textures/_SpaceCatsI/nterface/Alerts/shadowkin_power.rsi/meta.json)
| "y": 32 | ||
| }, | ||
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "DEATHB4DEFEAT#4404 (801294818839756811), modificated @CrimeMoot", |
There was a problem hiding this comment.
💡 Codebase verification
Based on the repository's license information and the analysis of other copyright notices in meta.json files, I can now provide a final response:
Рекомендуется изменить формат указания авторских прав
Текущий формат с Discord-тегом и ID не соответствует общепринятым практикам указания авторства в проекте. В большинстве других meta.json файлов используется более формальный подход.
Предлагаемый формат:
- "copyright": "DEATHB4DEFEAT#4404 (801294818839756811), modificated @CrimeMoot",
+ "copyright": "Оригинальная работа DEATHB4DEFEAT, модификация CrimeMoot (2025)"Причины:
- Публичное указание Discord ID может создавать проблемы с приватностью
- Формат должен быть более профессиональным и соответствовать общему стилю проекта
- Текущий формат содержит опечатку в слове "modificated"
- В других файлах проекта используется более формальный стиль указания авторства
🔗 Analysis chain
Проверьте формат указания авторских прав
Текущий формат указания авторских прав включает Discord-тег и ID. Рекомендуется использовать более формальный формат для указания авторства.
Убедитесь, что:
- Автор согласен на публичное указание Discord-идентификатора
- Формат соответствует требованиям лицензии CC-BY-SA-3.0
Предлагаемый формат:
- "copyright": "DEATHB4DEFEAT#4404 (801294818839756811), modificated @CrimeMoot",
+ "copyright": "Original work by DEATHB4DEFEAT, modified by CrimeMoot (2025)"Let me search for any copyright format requirements or similar files to verify the format.
Let me search for license files to verify the copyright format requirements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Error: No shell scripts found
Script:
#!/bin/bash
# Search for other meta.json files to compare copyright format
fd meta.json --exec cat {} \; | grep -i "copyright"
# Search for license files
fd -i license -e txt -e md | xargs cat
# Search for copyright-related documentation
fd -i copyright -e txt -e md | xargs cat
Length of output: 69374
Script:
#!/bin/bash
# Search for license files in the root directory
find . -maxdepth 1 -type f -iname "license*" -o -iname "copying*" | xargs cat
# Search for license information in README
find . -maxdepth 1 -type f -iname "readme*" | xargs cat
Length of output: 39084
Comment on lines
+5
to
+11
| whiteText: "#fcfeff" | ||
| slotSelectedGold: "#7bc2b2" | ||
| slotColor: "#7bc2b2" | ||
| slotOutline: "#7bc2b2" | ||
| slotText: "#7bc2b2" | ||
| nanoGold: "#7bc2b2" | ||
| goodGreenFore: "#7bc2b2" |
There was a problem hiding this comment.
Проблемы с доступностью цветовой схемы
Использование одинакового цвета (#7bc2b2) для различных элементов интерфейса может создать проблемы с читаемостью и доступностью. Рекомендуется:
- Использовать различные оттенки для разных элементов
- Обеспечить достаточный контраст для текста
colors:
whiteText: "#fcfeff"
- slotSelectedGold: "#7bc2b2"
- slotColor: "#7bc2b2"
- slotOutline: "#7bc2b2"
- slotText: "#7bc2b2"
+ slotSelectedGold: "#8ed4c4"
+ slotColor: "#6ab0a0"
+ slotOutline: "#5a9e8e"
+ slotText: "#ffffff"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| whiteText: "#fcfeff" | |
| slotSelectedGold: "#7bc2b2" | |
| slotColor: "#7bc2b2" | |
| slotOutline: "#7bc2b2" | |
| slotText: "#7bc2b2" | |
| nanoGold: "#7bc2b2" | |
| goodGreenFore: "#7bc2b2" | |
| whiteText: "#fcfeff" | |
| slotSelectedGold: "#8ed4c4" | |
| slotColor: "#6ab0a0" | |
| slotOutline: "#5a9e8e" | |
| slotText: "#ffffff" | |
| nanoGold: "#7bc2b2" | |
| goodGreenFore: "#7bc2b2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Вдохновлён визуальным стилем с https://github.com/EndrAnimet/DeltaV-Stray.
Большинство спрайтов являются портированием, т.к и лично моими стилями - которые отсутствовал или по моим меркам требуют изменение.
Summary by CodeRabbit
Новые функции
ActionCritSuccumb,ActionCritFakeDeath,ActionCritLastWordsВизуальные изменения
Улучшения