-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinygo support, goroutine hack change, fix panic for invalid stderr, add test #66
Conversation
indicate why we don't just use io.Discard, some more cc @ccoVeille
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
===========================================
- Coverage 100.00% 99.02% -0.98%
===========================================
Files 4 6 +2
Lines 550 618 +68
===========================================
+ Hits 550 612 +62
- Misses 0 4 +4
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: ccoVeille <[email protected]>
So I got it to link even though I have yet to get it to run with tinygo See but once these merge/are resolved, this will be tinygo compatible ps: because tinygo doesn't have stack traces the file name/line number tests do fail but it's ok |
Fixes #65
For tinygo (once debug.Buildinfo is fixed in tinygo-org/tinygo#4343) the issue was the linkname hacks that work for go do not exist, but there is instead a
internal/task.Current
that we use but convert to an id because... folks aren't convinced we need an id (even though we do...)Also switched to letting https://github.com/kortschak/goroutine deal with maintaining the hack (adds a dependency but... oh well)